<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"
	xmlns:content="http://purl.org/rss/1.0/modules/content/"
	xmlns:dc="http://purl.org/dc/elements/1.1/"
	xmlns:atom="http://www.w3.org/2005/Atom"
	xmlns:sy="http://purl.org/rss/1.0/modules/syndication/"
		>
<channel>
	<title>Comments on: How to not commit explicitly unreviewed changes in Mercurial</title>
	<atom:link href="http://whereswalden.com/2009/01/10/how-to-not-commit-explicitly-unreviewed-changes-in-mercurial/feed/" rel="self" type="application/rss+xml" />
	<link>http://whereswalden.com/2009/01/10/how-to-not-commit-explicitly-unreviewed-changes-in-mercurial/</link>
	<description>Mozilla, politics, economics, law, backpacking, cycling, and other random desiderata</description>
	<lastBuildDate>Tue, 31 Jan 2012 01:00:55 +0000</lastBuildDate>
	<sy:updatePeriod>hourly</sy:updatePeriod>
	<sy:updateFrequency>1</sy:updateFrequency>
	<generator>http://wordpress.org/?v=3.3.1</generator>
	<item>
		<title>By: Wladimir Palant</title>
		<link>http://whereswalden.com/2009/01/10/how-to-not-commit-explicitly-unreviewed-changes-in-mercurial/comment-page-1/#comment-126311</link>
		<dc:creator>Wladimir Palant</dc:creator>
		<pubDate>Sun, 11 Jan 2009 20:02:35 +0000</pubDate>
		<guid isPermaLink="false">http://whereswalden.com/?p=133#comment-126311</guid>
		<description>I guess Windows users can just put &quot;c:\mozilla-build\msys\bin\bash.exe&quot; in front of the script name.

But rather than searching for this specific string to be there I would be looking for /\br=\w+/ not being there. You can use whatever string to indicate that the patch isn&#039;t reviewed but a reviewed patch will always have &quot;r=something&quot; in the commit string.

[That was intentional, because sometimes I&#039;ll want to commit with something like &quot;Fix typo to kick tinderboxen into doing another build&quot; as the description (or some other such thing without adding a r= somewhere).  Also, Mozilla&#039;s style of indicating reviews probably doesn&#039;t extend to other open source projects that use Mercurial (or, for that matter, personal on-disk repositories).]</description>
		<content:encoded><![CDATA[<p>I guess Windows users can just put &#8220;c:\mozilla-build\msys\bin\bash.exe&#8221; in front of the script name.</p>
<p>But rather than searching for this specific string to be there I would be looking for /\br=\w+/ not being there. You can use whatever string to indicate that the patch isn&#8217;t reviewed but a reviewed patch will always have &#8220;r=something&#8221; in the commit string.</p>
<p>[That was intentional, because sometimes I'll want to commit with something like "Fix typo to kick tinderboxen into doing another build" as the description (or some other such thing without adding a r= somewhere).  Also, Mozilla's style of indicating reviews probably doesn't extend to other open source projects that use Mercurial (or, for that matter, personal on-disk repositories).]</p>
]]></content:encoded>
	</item>
	<item>
		<title>By: Justin Wood (Callek)</title>
		<link>http://whereswalden.com/2009/01/10/how-to-not-commit-explicitly-unreviewed-changes-in-mercurial/comment-page-1/#comment-126270</link>
		<dc:creator>Justin Wood (Callek)</dc:creator>
		<pubDate>Sun, 11 Jan 2009 06:31:15 +0000</pubDate>
		<guid isPermaLink="false">http://whereswalden.com/?p=133#comment-126270</guid>
		<description>I could be wrong but I think that windows users won&#039;t be able to use that hook.. I believe Hg under MozBuild is still the default win build of Hg, meaning it uses the windows shell not MSYS shell to execute this stuff.

Secondly for a &quot;buggy patch&quot; pre-hook thats both hard and easy.

Just cause it to build both debug and release Firefox, run full set of tests [to see if they pass], then check if any other commits happend since then, [re-]merge and push!  Probably not useful, due to turn-around-time though

[I expect people interested in using this could make any necessary changes, and to be frank, I don&#039;t care much about Windows here because I don&#039;t use it (for pushes, or for much of anything else, to be honest).  :-P  That said, when I installed the build toolchain on Windows a few days ago, the start-* scripts were spawning a bash shell, and the Mercurial there was responding to an hgrc in ~/.hgrc, so I&#039;m not so sure this doesn&#039;t work there.

&quot;Buggy patch&quot; was a joke about a hook that would be intelligent enough to find &lt;em&gt;any&lt;/em&gt; bug, not just ones that would show up in automated testing runs &#8212; solving-the-halting-problem sort of bugs, that is.]</description>
		<content:encoded><![CDATA[<p>I could be wrong but I think that windows users won&#8217;t be able to use that hook.. I believe Hg under MozBuild is still the default win build of Hg, meaning it uses the windows shell not MSYS shell to execute this stuff.</p>
<p>Secondly for a &#8220;buggy patch&#8221; pre-hook thats both hard and easy.</p>
<p>Just cause it to build both debug and release Firefox, run full set of tests [to see if they pass], then check if any other commits happend since then, [re-]merge and push!  Probably not useful, due to turn-around-time though</p>
<p>[I expect people interested in using this could make any necessary changes, and to be frank, I don't care much about Windows here because I don't use it (for pushes, or for much of anything else, to be honest).  <img src='http://whereswalden.com/wp-includes/images/smilies/icon_razz.gif' alt=':-P' class='wp-smiley' />   That said, when I installed the build toolchain on Windows a few days ago, the start-* scripts were spawning a bash shell, and the Mercurial there was responding to an hgrc in ~/.hgrc, so I'm not so sure this doesn't work there.</p>
<p>"Buggy patch" was a joke about a hook that would be intelligent enough to find <em>any</em> bug, not just ones that would show up in automated testing runs &mdash; solving-the-halting-problem sort of bugs, that is.]</p>
]]></content:encoded>
	</item>
</channel>
</rss>

