The latest addition to the Mozilla Framework Based on Templates (mfbt) is
mozilla/FloatingPoint.h. This header implements various floating point functionality.
mozilla/FloatingPoint.h currently implements the following functionality, all centered around working with double-precision floating point numbers. (There’s no single-precision support only because Mozilla seemingly doesn’t need it. The only code I can find that does this sort of thing for single-precision numbers is
nsCoord.h, and that only barely. We can add single-precision equivalents when we need them.)
- Determines whether a value is
NaN(not a number).
- Determines whether a value is positive or negative infinity.
- Determines whether a number is finite — that is, not
NaNor positive or negative infinity.
- Determines whether a number is negative. This is useful because
d < 0does not answer this question! There are two zero values,
-0, and IEEE-754 requires that
(-0 < 0)be false. (There are good reasons for this, but this isn’t the place to get into them. If you haven’t read it, read What Every Computer Scientist Should Know About Floating-Point Arithmetic right now. It probably gives the answer, and much much more knowledge as well.) This method properly distinguishes
-0as being negative.
- Determines whether a number is
- Returns the exponent portion of the number. Floating point numbers are represented as a sign bit
s, a binary fraction
b0..p, and an exponent
E. The represented number, then, is
(-1)s(b0..p)2E. This method returns the number
Efor a floating point number.
- Returns positive infinity.
- Returns negative infinity.
MOZ_DOUBLE_SPECIFIC_NaN(int signbit, uint64_t significand)
- Computes a specific
NaNvalue, with a bit pattern specified by provided parameters. The bit layout IEEE-754 specifies for floating point formats interestingly requires that multiple bit patterns be treated as
NaNvalues. This method allows the user to create such custom
NaNvalues if he needs to. (99% of code should never, ever touch this method. Instead, most code should use…)
- Computes an unspecified
NaNvalue. If you need a
NaNvalue and you don’t know that you need a specific
NaN, use this method instead to get one.
- Returns the smallest non-zero positive double value.
MOZ_DOUBLE_IS_INT32(double d, int32_t* i)
- Determines if the provided number is a signed 32-bit integer. (
-0doesn’t count as such;
+0, the “normal” zero value, does.) If it is,
*iwill be set to that value when the method returns.
(There’s one more method in the header, currently, that used to have users. Sometime in the last couple months, however, that method’s users all disappeared, and I didn’t notice it when rebasing. Thus I’ll be removing it shortly, and I haven’t mentioned it here.)
Why add some of these methods? Aren’t
isnan, and so on good enough?
There are standard methods implementing some (but not all) of this functionality. In the best of all possible worlds we could simply use
isnan and other such methods directly. In practice we’ve encountered a number of problems.
First, Microsoft’s compilers gratuitously Think Different and don’t expose
isnan and friends, so on those platforms you’d have to use
_isnan instead. (
std::isnan isn’t usable there because some of our code still must work as both C and C++.) Obviously, we don’t want to
#ifdef every place we need to use the method.
Second, we’ve found various compilers have bugs when using either the standard methods or Microsoft’s bogo-named methods. Most commonly this bustage occurs with PGO builds; interestingly, both MSVC and gcc have problems here, despite their optimizers obviously not sharing any code.
Third, we’ve found even some obvious bitwise algorithms trigger PGO build failures, again on entirely different compilers. (You can’t win.)
Basically, then, we can’t use the standard methods, we can’t use some bitwise methods, and whatever we do we have to be really careful about to make sure we don’t break anything. Hopefully this header will satisfy those requirements.
Where’s this header again?
The header is located at
mfbt/FloatingPoint.h in the source tree. However, per standard mfbt practice, you should use
#include "mozilla/FloatingPoint.h" to include it. Knock yourself out using it.